[Peek] WindowActivationState checks are added for focus and close aft… #26364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we having a tracking issue for this |
A new issue opened and added to PR. |
jaimecbernardo
added
the
Hot Fix
|
I'll be adding a Setting for enabling/disabling this behavior. |
|
Also need to check if this doesn't break #26349 |
I am also in favor of adding a Setting light dismiss. It can be very frustrating especially since it is not a window's normal behavior. |
|
I've added a setting for this, off by default: Also added a Service to the Peek.UI to get the settings, now that some settings influence it. |
stefansjfw
approved these changes
May 29, 2023
jaimecbernardo
added a commit
that referenced
this pull request
May 30, 2023
jaimecbernardo
added a commit
that referenced
this pull request
May 30, 2023
* catch exception * Check count of items to avoid the exception being thrown * Fix regression from #26364 --------- Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>
11 tasks
BLM16
pushed a commit
to BLM16/PowerToys
that referenced
this pull request
Jun 22, 2023
* [Peek] WindowActivationState checks are added for focus and close after losing focus. * Add setting to activate the behavior --------- Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>
BLM16
pushed a commit
to BLM16/PowerToys
that referenced
this pull request
Jun 22, 2023
…26470) * catch exception * Check count of items to avoid the exception being thrown * Fix regression from microsoft#26364 --------- Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er losing focus.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed