Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test loc fix #2 #26544

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Test loc fix #2 #26544

merged 2 commits into from
Jun 2, 2023

Conversation

crutkas
Copy link
Member

@crutkas crutkas commented Jun 1, 2023

Summary of the Pull Request

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@crutkas
Copy link
Member Author

crutkas commented Jun 1, 2023

The less than ideal option to fix loc, renamed resource file, it does compile and run.

jaimecbernardo
jaimecbernardo approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've changed the remaining files so they have the name change into account.

@crutkas crutkas merged commit 792a774 into main Jun 2, 2023
@crutkas crutkas deleted the testLocFix2 branch June 2, 2023 02:04
BLM16 pushed a commit to BLM16/PowerToys that referenced this pull request Jun 22, 2023
@crutkas @jaimecbernardo @BLM16
Test loc fix microsoft#2 (microsoft#26544)
9a978b3 
* Test loc fix microsoft#2

* Propagate the name change to the rest of the project

---------

Co-authored-by: Jaime Bernardo <jaime@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crutkas @jaimecbernardo