-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ImageResizer][Accessibility] Fix combo box text color #32573
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Yeah agreed, added that as comments. |
Co-authored-by: Niels Laute <niels.laute@live.nl>
Co-authored-by: Niels Laute <niels.laute@live.nl>
Merged commit suggestions. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Niels suggestions have been commited as-is
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Summary of the Pull Request
Light before

Light theme after

Dark theme before

Dark theme after

PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Tested with Colour contrast analyzer tool. Contrast is now 12.4:1 for light theme and 12.1:1 for dark theme.