Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImageResizer][Accessibility] Fix combo box text color #32573

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

stefansjfw
Copy link
Collaborator

Summary of the Pull Request

Light before
image

Light theme after
image

Dark theme before
image

Dark theme after
image

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Tested with Colour contrast analyzer tool. Contrast is now 12.4:1 for light theme and 12.1:1 for dark theme.

@Jay-o-Way

This comment was marked as outdated.

@niels9001
Copy link
Contributor

Isn't TextFillColorPrimaryBrush the default? I think it can be omitted

Yeah agreed, added that as comments.

stefansjfw and others added 2 commits April 22, 2024 19:14
Co-authored-by: Niels Laute <niels.laute@live.nl>
Co-authored-by: Niels Laute <niels.laute@live.nl>
Jay-o-Way

This comment was marked as outdated.

@stefansjfw
Copy link
Collaborator Author

Isn't TextFillColorPrimaryBrush the default? I think it can be omitted

Yeah agreed, added that as comments.

Merged commit suggestions. Thanks

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jaimecbernardo jaimecbernardo dismissed niels9001’s stale review April 23, 2024 13:12

Niels suggestions have been commited as-is

@jaimecbernardo
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stefansjfw stefansjfw merged commit 5b4da37 into main Apr 23, 2024
15 checks passed
@stefansjfw stefansjfw deleted the stefan/fix_32263 branch April 23, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants