Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Awake - DAISY build fix (pre-83) #34054

Merged
merged 69 commits into from
Jul 30, 2024
Merged

Awake - DAISY build fix (pre-83) #34054

merged 69 commits into from
Jul 30, 2024

Conversation

dend
Copy link
Collaborator

@dend dend commented Jul 29, 2024 •
edited
Loading

This PR addresses some post-merge issues caught by @davidegiacometti, including:

  1. Separator in the context menu shown when not running from inside PowerToys.
  2. "Keep display on" setting not persisting across switches between modes.
  3. Awake not launching in standalone mode.

Additionally:

  1. Exits are now properly handled in timed and expirable keep-awake modes when running standalone. This ensures that Awake exists after completion and doesn't switch to an in-actionable passive mode.
  2. Tray tooltips now cover how much time is left on the timer.
  3. Fixes PowerToys Awake - does not reflect the actual power status #29354
  4. Avoids a nasty memory leak because of re-instantiating of Icon objects for every tray update.
  5. Adds DPI awareness to the context menu (Awake tray menu is not mixed DPI aware #16123)

dend and others added 30 commits April 10, 2024 10:29
@dend
Cleanup and check UI-based state
ae527fb
@dend
Update Manager class to simplify settings handling
ca08069
@dend
Cleanup the code - we don't need to pass the constant to every call
b87863c
@dend
Cleanup and consolidation of functionality
f666863
@dend
Cleanup and proper tray bootstrap with settings
6044c8d
@dend
More cleanup
f293af1
@dend
More cleanup
6cd3e28
@dend
Update handling to remove redundant setting rewrites
fce629e
@dend
Move some strings to resources
a6f4b19
@dend
Cleaning up more redundancies
36fce10
@dend
General cleanup
b5ead48
@dend
Code cleanup
d8865e6
@dend
More general cleanup
6a8975c
@dend
First stage of removing Windows Forms and natively using Win32 API
82cdca1
@dend
Update parent window handle to HWND_MESSAGE
c3eef6f
@dend
Cleanup for consistency
5360d6b
@dend
More cleanup and consolidation
f0980c2
@dend
Merge branch 'microsoft:main' into main
b5107a5
@dend
Fix to the logic for native integration
a52b981
@dend
Code cleanup for unnecessary items
19435c2
@dend
Merge pull request #1 from microsoft/main
6bf1d56 
Sync changes
@crutkas
adding in spelling adjustments
4cffdd4
@dend
Fixing the menu and separators, along with icon tooltips
0fc378a
@dend
Merge remote-tracking branch 'origin/main'
160fa46
@dend
Remove unused code
4f1f08a
@dend
Update Awake planning doc
b2cca7d
@dend
Update planning doc
ccc80c8
@dend
Update package releases
01ff0a2
@crutkas
Update Directory.Build.props
39f9f1e
@crutkas
Fixing build error in CI. I believe a ton of these aren't needed. Exa…
89d7ed8 
…mple, History has a dependency on Mage...
dend and others added 15 commits July 23, 2024 15:58
@dend
Fix typo
f0b922c
@dend
Ensure that expirable keep-awake has a default in UI view
211dd7c 
This commit also removes the duplicated check for the expirable keep-awake target time.
@dend
Safeguards in Awake
014d4a5 
Make sure that when loading from a settings file, the expirable keep-awake is never in the past.
@dend
Fix when the tray changes for passive mode
651058e
@dend
Save settings on expiration change
55a7e79
@jaimecbernardo
Move icons to Awake assets folder
63771d2
@jaimecbernardo
Remove unneeded spellcheck expect entries
adfb399
@dend
Make sure the separator is only shown when launched from PT
ad37725
@dend
Merge remote-tracking branch 'origin/main'
7401dea
@dend
Merge branch 'main' of https://github.com/microsoft/PowerToys into mi…
8cd3538 
…crosoft-main
@dend
Merge branch 'microsoft-main'
fd3d222 
Merging changes
@dend
Fixes the issue with keeping display on resetting
6a56207
@dend
Make sure exits are properly handled when not using PT config
4b2e866
@dend
Remove unnecessary code
3d09025
@dend
Make sure that tooltips in the tray are useful
445d91a
@dend dend requested review from jaimecbernardo and crutkas July 29, 2024 22:49
@dend dend added the Needs-Review This Pull Request awaits the review of a maintainer. label Jul 29, 2024
@dend dend changed the title Awake - DAISY build polish Awake - DAISY build fix (pre-83) Jul 29, 2024
@dend dend mentioned this pull request Jul 30, 2024
Closed
@dend dend added the Product-Awake Issues regarding the PowerToys Awake utility label Jul 30, 2024
@dend dend mentioned this pull request Jul 30, 2024
Closed
1 task
jaimecbernardo
jaimecbernardo approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the quick fixes!

@jaimecbernardo jaimecbernardo merged commit e8ad4fa into microsoft:main Jul 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

@crutkas crutkas Awaiting requested review from crutkas

Assignees
No one assigned
Labels
Needs-Review This Pull Request awaits the review of a maintainer. Product-Awake Issues regarding the PowerToys Awake utility
Projects
5. Needs Attention
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PowerToys Awake - does not reflect the actual power status
3 participants
@dend @jaimecbernardo @crutkas