Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTRun][UnitConverter]Add usage prompt #35168

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

NaroZeol
Copy link
Contributor

@NaroZeol NaroZeol commented Oct 1, 2024

Summary of the Pull Request

Added usage prompt when a keyword is typed

PR Checklist

Detailed Description of the Pull Request / Additional comments

Added usage prompt when a keyword is typed

image

I'm not sure whether this usage prompt is enough. I tried adding the supported units, but the input box is too narrow to display them all. Any feedback welcomes

@htcfreek
Copy link
Collaborator

htcfreek commented Oct 1, 2024

Wondering if we show possible conversation if we know the first query part.

%% 10 ft to shows:

%% 10 ft to m
%% 10 ft to km
.....

@NaroZeol
Copy link
Contributor Author

NaroZeol commented Oct 1, 2024

Wondering if we show possible conversation if we know the first query part.

%% 10 ft to shows:

%% 10 ft to m
%% 10 ft to km
.....

Well, why not just show the results if you show so many prompts.

%% 10 ft shows:

304.8 cm
3.048 m
0.003048 km
........

It sounds great, but it's not a part of this PR.

We can do this in another one!

@NaroZeol NaroZeol marked this pull request as draft December 12, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants