[Deps] Upgrade System.IO.Abstractions #35656
Open
+67
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love this. |
davidegiacometti
force-pushed
the
users/davidegiacometti/sys-io-abstraction-upgrade
branch
from
620b2d2
to
896ea12
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jaimecbernardo
added
the
Needs-Review
jaimecbernardo
requested review from
crutkas,
DHowett and
ethanfangg
as code owners
| [DataRow(@"c:\Test>", 3, 3, true, DisplayName = "2 Folders recursive")] | ||
| [DataRow(@"c:\not-exist>", 3, 3, true, DisplayName = "Folder not exist, return root recursive")] | ||
| [DataRow(@"c:\Test>", 3, 0, true, DisplayName = "2 Folders recursive")] | ||
| [DataRow(@"c:\not-exist>", 3, 0, true, DisplayName = "Folder not exist, return root recursive")] |
There was a problem hiding this comment.
Interesting, folders stopped being reported as files as well?
There was a problem hiding this comment.
Not clear but there is something weird on mock file system side (previous returned items were wrong too). I think we can keep the test anyway. Plugin is working as expected.
|
EDIT: my bad, ignore the previous statement. Thanks for adding them to signing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
PowerToys is still using an old version of System.IO.Abstraction, dated 2022: https://www.nuget.org/packages/System.IO.Abstractions
This PR upgrade it to the latest stable version and address changes.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Reduce dependency/complexity a little bit: Common Logger and Language Helper aren't tested and the file system abstraction isn't really needed.
Asserts were wrong even using previous package version. It seems that the mocked file system is acting differently while enumerating files and folders. Think we shouldn't remove these tests in case it will be fixed in future releases.
Validation Steps Performed