-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Laucher] Added border on W10 #36392
[Laucher] Added border on W10 #36392
Conversation
This is best reviewed hiding whitespace chances in the diff. Main reason is that diff is showing badly the identation changes in the XAML file from adding the Border tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Davide Giacometti <25966642+davidegiacometti@users.noreply.github.com>
Co-authored-by: Davide Giacometti <25966642+davidegiacometti@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you
Summary of the Pull Request
Added a border on W10 since only W11 had it.
Screenshots of the new look in W10.
PR Checklist
Detailed Description of the Pull Request / Additional comments
ResizeMode="NoResize" removes the border which on W11 was added back by enabling round corners
Added a gray border on W10.
Validation Steps Performed
Tested On W10 and W11 on dark,light and all high contrast modes.