Fix for the issue where PT Run was preventing UWP apps from building in VS#5109
Merged
alekhyareddy28 merged 5 commits intomicrosoft:masterfrom Jul 21, 2020
Merged
Conversation
dsrivastavv
reviewed
Jul 20, 2020
src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/PackageWrapper.cs
Show resolved
Hide resolved
src/modules/launcher/Plugins/Microsoft.Plugin.Program/Programs/UWP.cs
Outdated
Show resolved
Hide resolved
ryanbodrug-microsoft
approved these changes
Jul 21, 2020
Contributor
ryanbodrug-microsoft
left a comment
There was a problem hiding this comment.
LGTM Thanks
VictoriousRaptor
added a commit
to VictoriousRaptor/Flow.Launcher
that referenced
this pull request
Oct 21, 2022
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Argument Exception.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Argument Exceptionwas being thrown when whenpackage.InstalledLocation.Pathwas being accessed. It threw a value is not found in the expected range exception.ArgumentNullExceptionorArgumentOutOfRangeExceptionso other than catching the exception, no other check could be performed.deny_writeSTGM constant which prevented any other process from modifying it. This was causing all the appxmanifest.xml files to be locked by PowerToys run. Changing it todeny_nonefixed this issue. Ref - https://docs.microsoft.com/en-us/windows/win32/stg/stgm-constants. We will not face an issue where we would try to read an incompletely installed packaged app because we proceed only if the installation is complete (using args.IsComplete).Validation Steps Performed