[Launcher] Kill the Launcher immediately #6747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricogior
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
This was discussed off-line, the proper fix will be done after #6660 is merged
ivan100sic
force-pushed
the
kill-launcher
branch
from
de24ff5 to
77624c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This is a temporary fix to close the Launcher immediately when the PowerToy is disabled, or PowerToys exits cleanly/is restarted as admin.
PR Checklist
Info on Pull Request
Don't wait for Launcher to exit when it's sent a message, because right now it doesn't seem to react to it. We should keep looking for a proper way to fix this.
Validation Steps Performed
Scenario 1: Disable Launcher. It should quit immediately.
Scenario 2: Restart PT as admin. The launcher will keep the old instance of PowerToys.exe running for 10 more seconds. When it finally quits, the launcher will also quit and so it needs to be restarted manually. This PR also fixed this bug.