Add e to calculator#9124
Merged
enricogior merged 3 commits intomicrosoft:masterfrom Jan 19, 2021
pavelzw:e
Merged
Conversation
enricogior
added
the
Run-Plugin
ivan100sic
reviewed
Jan 19, 2021
src/modules/launcher/Plugins/Microsoft.Plugin.Calculator/CalculateEngine.cs
Show resolved
Hide resolved
1234567-glitch
approved these changes
Jan 19, 2021
ivan100sic
reviewed
Jan 19, 2021
src/modules/launcher/Plugins/Microsoft.Plugin.Calculator/CalculateEngine.cs
Outdated
Show resolved
Hide resolved
ivan100sic
approved these changes
Jan 19, 2021
Contributor
ivan100sic
left a comment
ivan100sic
left a comment
There was a problem hiding this comment.
Good job! Works well, I also verified that you can still enter floats using e-notation, so no worries about that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
This adds support for the euler number to the calculator.
What is included in the PR:
How does someone test / validate:
2*e,e^5,log(e)Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.