Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update infra delete #746

Merged
merged 7 commits into from
Jun 13, 2024
Merged

update infra delete #746

merged 7 commits into from
Jun 13, 2024

Conversation

wotey
Copy link
Contributor

@wotey wotey commented Jun 10, 2024

Update infra delete to remove ao_ai permissions

@wotey wotey marked this pull request as ready for review June 11, 2024 03:24
@wotey
Copy link
Contributor Author

wotey commented Jun 11, 2024

This pull request includes changes to the scripts/inf-destroy.sh and scripts/inf-manual-destroy.sh scripts to manage Azure resources. The changes primarily involve the addition of commands to delete role assignments and prompt the user for additional information.

The most important changes are:

  • scripts/inf-destroy.sh: Added commands to delete role assignments associated with the Azure resource group. This is done by first retrieving the appId of the service principal and the role_assignment_id of the role assignment, and then deleting the role assignment using these identifiers.

  • scripts/inf-manual-destroy.sh:

    • Added prompts to ask the user for the name of the OpenAI resource group connected to their resource group. This is done to retrieve the oa_ai_rg_name which is used later in the script.
    • Added commands to delete the OpenAI connection. This is done by first retrieving the appId of the service principal and the role_assignment_id of the role assignment, and then deleting the role assignment using these identifiers.
    • Added extra line breaks for better readability of the script.

scripts/inf-destroy.sh Outdated Show resolved Hide resolved
@dayland dayland merged commit a34d4d1 into vNext-Dev Jun 13, 2024
3 checks passed
@dayland dayland deleted the wotey/destroy branch June 13, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants