Push images to ACR with v2 REST APIs #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to private DNS resolution challenges with the Azure Container Registry and
docker loginoraz acr loginwe needed to switch to the REST APIs for loading the docker images into the ACR.In this PR we have changed from a simple push form the docker-daemon to Azure Container Registry to a process by which we use the library skopeo to export the image in OCI format and then upload the layers, manifest, and config using the v2 REST APIs. The building and uploading of container has also been streamlined into the individual make commands for
make deploy-webapp,make deploy-functions, andmake deploy-enrichments