Updated to full connection string to support all regions #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wotey
approved these changes
Sep 5, 2024
dayland
deleted the
dayland/7950-update-storage-connection-string-to-work-in-all-regions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on cleaning up and simplifying the configuration and output of storage-related settings in the infrastructure files. The most important changes include the removal of several output variables and the modification of a storage connection string reference.
Removal of Output Variables:
infra/core/host/functions/outputs.tf: Removed output variablesAzureWebJobsStorage__accountName,AzureWebJobsStorage__blobServiceUri, andSTORAGE_CONNECTION_STRING__accountName.infra/outputs.tf: Removed output variablesFUNC_AzureWebJobsStorage__accountName,FUNC_AzureWebJobsStorage__blobServiceUri, andFUNC_STORAGE_CONNECTION_STRING__accountName.Modification of Storage Connection String:
infra/core/storage/storage-account.tf: Changed thesecret_valueto useazurerm_storage_account.storage.primary_connection_stringinstead ofazurerm_storage_account.storage.primary_blob_connection_string.Script Adjustments:
scripts/json-to-env.function.debug.sh: Removed entries related toFUNC_AzureWebJobsStorage__accountName,FUNC_AzureWebJobsStorage__blobServiceUri, andFUNC_STORAGE_CONNECTION_STRING__accountName.