Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units and is_setpoint is not propagated by _parameter_arrays #499

Closed
jenshnielsen opened this issue Feb 20, 2017 · 2 comments
Closed

Units and is_setpoint is not propagated by _parameter_arrays #499

jenshnielsen opened this issue Feb 20, 2017 · 2 comments
Milestone

Comments

@jenshnielsen
Copy link
Collaborator

For instance for a simple multiparameter with one array


Out[8]:
{'__class__': 'qcodes.data.data_array.DataArray',
 'action_indices': (0, 0),
 'array_id': 'MyMockAlazar_rawname',
 'instrument': '__main__.MockAlazar',
 'instrument_name': 'MyMockAlazar',
 'is_setpoint': False,
 'label': 'rawlabel',
 'labels': ('rawlabel',),
 'name': 'rawname',
 'names': ('rawname',),
 'setpoint_labels': (('timelabel',),),
 'setpoint_names': (('timename',),),
 'shape': (629,),
 'unit': None,
 'units': ('v',)}

and

{'__class__': 'qcodes.data.data_array.DataArray',
 'action_indices': (0,),
 'array_id': 'timename',
 'is_setpoint': False,
 'label': 'timelabel',
 'name': 'timename',
 'shape': (629,),
 'unit': None}

Fix coming up in a few minuts

@giulioungaretti
Copy link
Contributor

this will be closed by #512, right ?

@jenshnielsen
Copy link
Collaborator Author

Yes

giulioungaretti pushed a commit that referenced this issue Mar 7, 2017
* Fix: Partial fix for #499 propagate units to subarray

* Fix: This is a setpoint array by definition

* fix: test_loop rename setpoint arrays

* fix: test_measure rename setpoint arrays

* Fix: Add setpoint_units to Array and Multiparameter

* Fix: add handling of setpoint units to loops

* Add test for multiparameter units setpoint_units

* Remove assert

* Add setpoint_units to meta_arrr so its correctly shapshoted

* Fix: remove unused variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants