Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config breaks on upstream updates. #519

Closed
giulioungaretti opened this issue Mar 10, 2017 · 1 comment · Fixed by #520
Closed

Config breaks on upstream updates. #519

giulioungaretti opened this issue Mar 10, 2017 · 1 comment · Fixed by #520
Assignees
Labels

Comments

@giulioungaretti
Copy link
Contributor

If a user had a custom config and we update upstream by adding a new field.
Their config value will remove the new field added upstream, thus breaking the import of qcodes!

The other way around is impossible to prevent though. If we remove a field upstream there's no way to delete it locally ,or even to raise a warning , but that's cool because maybe local uncommitted doe depends on it :D At worst it's a bit of extra noise!

@giulioungaretti
Copy link
Contributor Author

thanks @eendebakpt and @nataliejpg and @MerlinSmiles for spotting my horrible 🐛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant