Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delays, negative and otherwise #116

Merged
merged 10 commits into from
Apr 26, 2016
Merged

Delays, negative and otherwise #116

merged 10 commits into from
Apr 26, 2016

Conversation

alexcjohnson
Copy link
Contributor

Changes to how we handle delays in loops and parameters, per QCoDeS/Qcodes_loop#13 :

  • delay=0 is the default in Loops, and does not emit any "negative delay" warnings
  • delay and step are separated and renamed in StandardParameter:
    • sweep_step -> step
    • sweep_delay -> delay
    • max_sweep_delay -> max_delay
    • the old names still work (and in fact I haven't updated the tests or existing drivers with the new names yet, but I will do that before this is merged) but will be removed as soon as people have had a chance to merge this into their WIP branches.
    • your parameter can have a delay even if it doesn't have a step - which is the main reason for the name changes, really.

cc @damazter @AdriaanRol @akhmerov @MerlinSmiles

@damazter
Copy link
Contributor

damazter commented Apr 26, 2016

The conflicts make it a tiny bit hard to test,
but it seems to work fine with my simulation branch upon merging anyway.
I did not look at the code, though.
It would be a dancer if not for your own comment:

the old names still work (and in fact I haven't updated the tests or existing drivers with the new names yet, but I will do that before this is merged) but will be removed as soon as people have had a chance to merge this into their WIP branches.

@alexcjohnson
Copy link
Contributor Author

Actually it looks like there's very little use yet of stepped setters and delays, including exactly none in any of the WIP branches people have published... I've taken out the deprecation code, ONLY the new names are allowed now. Good to go?

@damazter
Copy link
Contributor

💃 💃 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants