MiniCircuits: wrong USB packet size resulting in error on Windows 7 #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...which results in the driver not working on windows 7. note that the driver works fine without the fix on windows 10.
astafan8
requested review from
jenshnielsen,
WilliamHPNielsen and
Dominik-Vogel
Codecov Report
@@ Coverage Diff @@
## master #1366 +/- ##
=======================================
Coverage 73.15% 73.15%
=======================================
Files 79 79
Lines 9156 9156
=======================================
Hits 6698 6698
Misses 2458 2458 |
Dominik-Vogel
approved these changes
Nov 2, 2018
| **kwargs) ->None: | ||
|
|
||
| def __init__(self, name: str, instance_id: str=None, timeout: float=2, | ||
| **kwargs): |
There was a problem hiding this comment.
wow you are so up to date. This was only in September:
python/mypy#5677
sohailc
reviewed
Nov 5, 2018
sohailc
reviewed
Nov 5, 2018
sohailc
approved these changes
Nov 5, 2018
|
Other then a small comment about docstrings, I think this is good to go |
|
The fix of the flaky test seems to have worked, all lights are green :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1361 (which was introduced in #1073). Also some cosmetic modifications (see commit messages).
Closes #703. (Shall it, @QCoDeS/core ?)
Note that a more elaborate driver is being developed in #813.