Unify default values of arguments for all snapshot_base and snapshot methods in qcodes repo

qcodes/instrument/channel.py

@@ -391,7 +391,7 @@ def lock(self) -> None:
         self._channels = tuple(self._channels)
         self._locked = True
 
-    def snapshot_base(self, update: bool = True,
+    def snapshot_base(self, update: bool = False,
                       params_to_skip_update: Optional[Sequence[str]] = None
                       ) -> Dict:
         """

qcodes/instrument/parameter.py

@@ -406,7 +406,7 @@ def __call__(self, *args: Any, **kwargs: Any) -> Optional[ParamDataType]:
                 raise NotImplementedError('no set cmd found in' +
                                           ' Parameter {}'.format(self.name))
 
-    def snapshot_base(self, update: bool = True,
+    def snapshot_base(self, update: bool = False,
                       params_to_skip_update: Optional[Sequence[str]] = None
                       ) -> Dict:
         """
@@ -1333,7 +1333,7 @@ def get_raw(self) -> Any:
     def set_raw(self, value: Any) -> None:
         self.source(value)
 
-    def snapshot_base(self, update: bool = True,
+    def snapshot_base(self, update: bool = False,
                       params_to_skip_update: Optional[Sequence[str]] = None
                       ) -> Dict:
         snapshot = super().snapshot_base(

qcodes/instrument/visa.py

@@ -228,7 +228,7 @@ def ask_raw(self, cmd: str) -> str:
             self.visa_log.debug(f"Response: {response}")
         return response
 
-    def snapshot_base(self, update: bool = True,
+    def snapshot_base(self, update: bool = False,
                       params_to_skip_update: Optional[Sequence[str]] = None
                       ) -> Dict:
         """

qcodes/instrument_drivers/ZI/ZIHDAWG8.py

@@ -66,7 +66,7 @@ def __init__(self, name: str, device_id: str, **kwargs) -> None:
         self.warnings_as_errors: List[str] = []
         self._compiler_sleep_time = 0.01
 
-    def snapshot_base(self, update: bool = True,
+    def snapshot_base(self, update: bool = False,
                       params_to_skip_update: Optional[Sequence[str]] = None
                       ) -> Dict:
         """ Override the base method to ignore 'feature_code' by default."""

qcodes/instrument_drivers/ZI/ZIUHFLI.py

@@ -1652,7 +1652,7 @@ def __init__(self, name: str, device_ID: str, **kwargs) -> None:
                            docstring="Enable jumbo frames on the TCP/IP interface"
                            )
 
-    def snapshot_base(self, update: bool = True,
+    def snapshot_base(self, update: bool = False,
                       params_to_skip_update: Optional[Sequence[str]] = None
                       ) -> Dict:
         """ Override the base method to ignore 'sweeper_sweeptime' if no signals selected."""

qcodes/station.py

@@ -131,7 +131,7 @@ def __init__(self, *components: Metadatable,
 
         self.load_config_file(self.config_file)
 
-    def snapshot_base(self, update: bool = True,
+    def snapshot_base(self, update: bool = False,
                       params_to_skip_update: Optional[Sequence[str]] = None
                       ) -> Dict:
         """
@@ -361,7 +361,7 @@ def load_config(self, config: Union[str, IO[AnyStr]]) -> None:
 
         def update_station_configuration_snapshot():
             class StationConfig(UserDict):
-                def snapshot(self, update=True):
+                def snapshot(self, update=False):
                     return self
 
             self.components['config'] = StationConfig(self._config)

qcodes/tests/instrument_mocks.py

@@ -514,7 +514,7 @@ def _getter(self, name: str):
         self._get_calls[name] += 1
         return val
 
-    def snapshot_base(self, update: bool = True,
+    def snapshot_base(self, update: bool = False,
                       params_to_skip_update: Optional[Sequence[str]] = None
                       ) -> Dict:
         if params_to_skip_update is None: