-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Measurement loop #4074
Open
nulinspiratie
wants to merge
167
commits into
microsoft:main
Choose a base branch
from
nulinspiratie:feature/measurement-loop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/Measurement loop #4074
nulinspiratie
wants to merge
167
commits into
microsoft:main
from
nulinspiratie:feature/measurement-loop
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@nulinspiratie Thanks a lot, I am super busy this week but I promise to get back to this ASAP |
for more information, see https://pre-commit.ci
it can cause mistakes
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new way of doing measurements, called the
MeasurementLoop
, that sits somewhere in between the currentMeasurement
class and thedo1d/do2d/dond
functions. The key idea of this measurement scheme is to offer flexibility in measurements while having as much as possible be implicit.The
MeasurementLoop
introduced here is ported from the UNSW forkMeasurement
class.Although the basic functionality is working, this PR is still very much a work in progress, but I thought of starting the PR now. Is this something that could fit into QCoDeS?
Tagging @jenshnielsen @WilliamHPNielsen @RasmusBC59
Features
Sweep
classNested measurements recognize that they are nested and attach themselves to the parent measurement.
This enables functions that perform a measurement. If the function is called within a measurement, it becomes part of the larger measurement
Limitations
This can be implemented.
Illustrative example
To do items
__all__
ofmeasurement_loop.py
Sweep.execute()
Additions in future PR's
MeasurementLoop
Tests to add