Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add basic driver for Keithley 2400 #488

Merged

Conversation

WilliamHPNielsen
Copy link
Contributor

This is a clean-up of PR #235. I suspect buggy behaviour but have not tested the driver.

Changes proposed in this pull request:

  • Add a basic driver
  • No example notebook

@jenshnielsen

This is a clean-up of PR microsoft#235. I suspect buggy behaviour but have not tested the driver.
@giulioungaretti
Copy link
Contributor

@WilliamHPNielsen I propose to merge this in anyway.
What is the bugginess you suspect?

@WilliamHPNielsen
Copy link
Contributor Author

@giulioungaretti Suspect is perhaps a strong word. But I have no way of knowing that the msg referenced in the parser functions has the right format (and that it ALWAYS has it) before I do/see a test.

@jenshnielsen jenshnielsen mentioned this pull request Mar 9, 2017
@giulioungaretti giulioungaretti merged commit 0e3ad1b into microsoft:master Mar 9, 2017
giulioungaretti pushed a commit that referenced this pull request Mar 9, 2017
Author: William H.P. Nielsen <whpn@mailbox.org>

    feat: Add basic driver for Keithley 2400 (#488)
@WilliamHPNielsen WilliamHPNielsen deleted the driver/Keithley2400 branch May 16, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants