Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rigol dg4000 value mappings #6345

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

konosubakonoakua
Copy link
Contributor

fix value mappings

@konosubakonoakua konosubakonoakua requested a review from a team as a code owner August 13, 2024 08:36
@konosubakonoakua
Copy link
Contributor Author

DG4000 cannot be upgraded with an arbitrary U disk.

I have consulted with Rigol Tech support, They said it's better to send my device to them.
Their engineer can do the upgrade. However, I don't have time to wait for that.
IMO, I should leave this PR open in case someone else have encountered the same issue.

@konosubakonoakua
Copy link
Contributor Author

@jenshnielsen I have restore the parser to int, please review again.

@jenshnielsen
Copy link
Collaborator

@konosubakonoakua Should be good to go, just waiting on clarity on the last question inline

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@5d9afec). Learn more about missing BASE report.
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...rc/qcodes/instrument_drivers/rigol/Rigol_DG4000.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6345   +/-   ##
=======================================
  Coverage        ?   67.34%           
=======================================
  Files           ?      352           
  Lines           ?    32139           
  Branches        ?        0           
=======================================
  Hits            ?    21645           
  Misses          ?    10494           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue Sep 24, 2024
Merged via the queue into microsoft:main with commit badc122 Sep 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants