Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building of docs using 3.13 #6585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Nov 1, 2024

Now that wrapt 1.17.0 is released we can build docs with 3.13

Lifted from #6494 since this is currently failing.

Issue is resolved in wrapt 1.17.0rc1 just need to wait for release and we can merge this

Disabling parallel build does not seem to make a difference.

Disabling the extensions one by one seems to indicate that the docs build error is related to autodocsumm, other debugging points towards viewsource. It may be a combination of these extensions

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.37%. Comparing base (7b23604) to head (9c6e294).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6585   +/-   ##
=======================================
  Coverage   69.37%   69.37%           
=======================================
  Files         340      340           
  Lines       31322    31322           
=======================================
  Hits        21729    21729           
  Misses       9593     9593           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jenshnielsen jenshnielsen force-pushed the python_313_docs branch 2 times, most recently from daaa1f9 to 71110c0 Compare November 1, 2024 09:48
@jenshnielsen
Copy link
Collaborator Author

jenshnielsen commented Nov 1, 2024

Disabling viewcode confirms that this also fixes the issue.

Some debugging specifically adding

        if not isinstance(modname, str):
            raise RuntimeError(f"Expected str but got {modname} {fullname} {docname} {refname}")

In sphinx viewcode.py here

def doctree_read(app: Sphinx, doctree: Node) -> None:
    env = app.builder.env
    if not hasattr(env, '_viewcode_modules'):
        env._viewcode_modules = {}  # type: ignore[attr-defined]

    def has_tag(modname: str, fullname: str, docname: str, refname: str) -> bool:
        if not isinstance(modname, str):
            raise RuntimeError(f"Expected str but got {modname} {fullname} {docname} **{refname}")**

Reveals that this is a problem with connectionplus probably related to wrapt

Handler <function doctree_read at 0x000001A4DE833240> for event 'doctree-read' threw an exception (exception: Expected str but got <property object at 0x000001A4DCE3F740> ConnectionPlus api/dataset/index qcodes.dataset)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant