This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Use R1 rather than Rz #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R1 actually matches the requirements.
tcNickolas
approved these changes
Jul 13, 2019
There was a problem hiding this comment.
This makes sense, thank you! We should probably modify the testing harness for the tasks which require applying a unitary to validate a controlled version of the unitary (well, for the tasks which have controlled version) - this way the extra global phase will be recognized and rejected.
tcNickolas
added a commit
that referenced
this pull request
Jul 15, 2019
As was pointed out in #146, task solutions which add extra global phase can be confusing for the learner. This change modifies the test harnesses for part I to check that the solutions do exactly the transformation required and to fail if the solution adds a global phase.
tcNickolas
added a commit
that referenced
this pull request
Jul 16, 2019
As was pointed out in #146, task solutions which add extra global phase can be confusing for the learner. This change modifies the test harnesses for part I to check that the solutions do exactly the transformation required and to fail if the solution adds a global phase.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R1 actually matches the requirements.
I know that the computer can't distinguish between the two and they are only differ by a global phase, but I think using Rz is confusing to people who are trying to learn.