Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update model_experiment.py to support basic EDA #220

Merged
merged 8 commits into from
Aug 26, 2024

Conversation

xisen-w
Copy link
Collaborator

@xisen-w xisen-w commented Aug 21, 2024

Revised model_experiment.py to implement the property source_data so that the system is able to look into the data first before the proposal.

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

It looks into the data first before the proposal.
@xisen-w xisen-w changed the title Update model_experiment.py to support basic eda feat: update model_experiment.py to support basic EDA Aug 21, 2024
@WinstonLiyt WinstonLiyt merged commit bf2684c into main Aug 26, 2024
7 checks passed
@WinstonLiyt WinstonLiyt deleted the Xisen-Wang-support-eda branch August 26, 2024 08:38
WinstonLiyt added a commit that referenced this pull request Aug 28, 2024
* Update model_experiment.py to support basic eda

It looks into the data first before the proposal.

* Update model_experiment.py

Revised linting

* Update model_experiment.py by fixing sorting order

* Update model_experiment.py for black linting

* Update model_experiment.py

* Update model_experiment.py

* Update model_experiment.py

* Update model_experiment.py

---------

Co-authored-by: WinstonLiyt <104308117+WinstonLiyt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants