[Python] Add Portuguese support for DateTimeV2 #2876
Conversation
|
@samhickey25, BTW, I noticed that in the fork where this PR comes from you folks seem to have Python support for Italian Numbers. Are you also looking at contributing that back? That would be very helpful. As well as any other contributions. :-) |
tellarin
changed the title
|
I think we'll get to Italian but at the moment I'm just concentrating on Portuguese support |
| PortugueseDateTime.Tomorrow) else 0 | ||
|
|
||
| # handle Date followed by morning, afternoon | ||
| # Add handling code to handle morning, afternoon followed by Date |
There was a problem hiding this comment.
Is this replicating the state of the .NET code or a Python-specific workaround?
There was a problem hiding this comment.
This is replicating .NET behaviour
| @@ -695,7 +695,7 @@ | |||
| }, | |||
| { | |||
| "Input": "Você está livre em 13.5.2015", | |||
| "NotSupported": "python", | |||
| "NotSupported": "", | |||
There was a problem hiding this comment.
Such empty NotSupported tags can be removed to keep specs clean.
| @@ -1396,7 +1396,7 @@ | |||
| "Context": { | |||
| "ReferenceDateTime": "2016-11-07T00:00:00" | |||
| }, | |||
| "NotSupported": "python", | |||
| "NotSupported": "", | |||
| @@ -883,7 +883,7 @@ | |||
| }, | |||
| { | |||
| "Input": "Voltarei às 7h01", | |||
| "NotSupported": "python", | |||
| "NotSupported": "", | |||
Yeah these files follow the .NET files and behaviour closely |
| @@ -54,7 +54,7 @@ def parse_specific_time_of_day(self, source: str, reference: datetime) -> DateTi | |||
|
|
|||
| # handle Date followed by morning, afternoon | |||
| # Add handling code to handle morning, afternoon followed by Date | |||
| # Add handling code to handle early/late morning, afternoon | |||
| # Add handling code to handle early/late morning, afternoon. | |||
There was a problem hiding this comment.
No need for such commits. We can either re-run the same build. Or close/reopen the PR and a new build is triggered.
There was a problem hiding this comment.
A new build is already running.
* Add Portuguese DateTime support in Python * Update Specs with Python changes * Fix Number import issue * Update specs according to build and review * Remove empty NotSupported fields from specs
Add support for datetime entities in python for Portuguese and update the Specs to reflect these changes