Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key access for collections with spaces in the keys #242

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Rhohand
Copy link

@Rhohand Rhohand commented Jul 15, 2019

Fixes # .

Changes proposed in this pull request:

How to test this code:

  • Use a report server with a space in the namespace
  • Open a proxy connection
  • Invoke New-RsFolder with a new folder
  • Expected: Folder is added
  • Actual: Line:91 in New-RsFolder will break: $additionalProperties = New-Object System.Collections.Generic.List[$propertyDataType] as there will be a space in the key.

Has been tested on (remove any that don't apply):

  • Powershell 5 and above
  • Windows 10 and above
  • SQL Server 2008 R2 and above

@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ Rhohand sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@jtarquino
Copy link
Member

@Rhohand just waiting for you to sign the license/cla to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants