Added strongname signing for RulesEngine (#231)

* Added strongname signing
microsoft · Sep 9, 2021 · 1449d05 · 1449d05
1 parent 7b089a8
commit 1449d05
Show file tree

Hide file tree

Showing 8 changed files with 29 additions and 68 deletions.
diff --git a/.github/workflows/nuget-publish-github.yml b/.github/workflows/nuget-publish-github.yml
diff --git a/.github/workflows/nuget-publish.yml b/.github/workflows/nuget-publish.yml
diff --git a/.gitignore b/.gitignore
@@ -330,4 +330,8 @@ ASALocalRun/
 .mfractor/
 /src/RulesEngine/RulesEngine.sln.licenseheader
 /assets/RulesEnginePackageFile.xml
-coveragereport/
+coveragereport/
+
+src/**/*.snk
+
+dist
diff --git a/deployment/build-signed.ps1 b/deployment/build-signed.ps1
@@ -0,0 +1,15 @@
+param(
+    [Parameter(Mandatory)]
+    [string] $csprojFilePath,
+    [Parameter(Mandatory)]
+    [string] $signingKey
+)
+
+# sign and build the project
+$directory = Split-Path $csprojFilePath;
+$signKeyFile = Join-Path $directory "signKey.snk";
+
+$bytes = [Convert]::FromBase64String($signingKey)
+[IO.File]::WriteAllBytes($signKeyFile, $bytes)
+
+dotnet build $csprojFilePath -c Release -p:ContinuousIntegrationBuild=true -p:DelaySign=false -p:AssemblyOriginatorKeyFile=$signKeyFile 
diff --git a/signing/RulesEngine-publicKey.snk b/signing/RulesEngine-publicKey.snk
diff --git a/src/RulesEngine/Properties/AssemblyInfo.cs b/src/RulesEngine/Properties/AssemblyInfo.cs
@@ -8,4 +8,4 @@
 // to COM components.  If you need to access a type in this assembly from 
 // COM, set the ComVisible attribute to true on that type.
 [assembly: ComVisible(false)]
-[assembly: InternalsVisibleTo("RulesEngine.UnitTest")]
+[assembly: InternalsVisibleTo("RulesEngine.UnitTest, PublicKey=0024000004800000940000000602000000240000525341310004000001000100c15956b2ac0945c55b69a185f5c3e02276693b0a5e42c8a1f08cb24e03dd87d91f9fa09f79b6b7b3aac4df46f2ea4ce4bfa31920bb0aad9f02793ab29de9fbf40f5ba9e347aa8569128459f31da1f6357eabe6e1308ac7c16b87a4d61e8d1785746a57ec67956d2e2454b3c98502a5d5c4a4168133bfaa431207c108efae03aa")]
diff --git a/src/RulesEngine/RulesEngine.csproj b/src/RulesEngine/RulesEngine.csproj
@@ -19,6 +19,11 @@
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
+    <SignAssembly>True</SignAssembly>
+    <AssemblyOriginatorKeyFile>..\..\signing\RulesEngine-publicKey.snk</AssemblyOriginatorKeyFile>
+    <DelaySign>True</DelaySign>
+    <Deterministic>true</Deterministic>
+    <EmbedUntrackedSources>true</EmbedUntrackedSources>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/test/RulesEngine.UnitTest/RulesEngine.UnitTest.csproj b/test/RulesEngine.UnitTest/RulesEngine.UnitTest.csproj
@@ -1,6 +1,9 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFramework>netcoreapp3.1</TargetFramework>
+    <SignAssembly>True</SignAssembly>
+    <AssemblyOriginatorKeyFile>..\..\signing\RulesEngine-publicKey.snk</AssemblyOriginatorKeyFile>
+    <DelaySign>True</DelaySign>
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="AutoFixture" Version="4.17.0" />