Documentation Error for ntt_negacyclic_harvey_lazy

[fionser]

Hi,

It say that the forward ntt works in the [0, 2p) domain.

https://github.com/microsoft/SEAL/blob/master/native/src/seal/util/smallntt.cpp#L229

Should it be [0, 4p) ?

[WeiDaiWD]

You are right. Inputs should be 2p-bounded. Outputs are 4p-bounded. This comment will be fixed in a future minor release. Thanks a lot! Regards, Wei Dai

…

________________________________ From: riku Lu <notifications@github.com> Sent: Thursday, August 29, 2019 12:21:42 AM To: microsoft/SEAL <SEAL@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: [microsoft/SEAL] Documentation Error for ntt_negacyclic_harvey_lazy (#56) Hi, It say that the forward ntt works in the [0, 2p) domain. https://github.com/microsoft/SEAL/blob/master/native/src/seal/util/smallntt.cpp#L229<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FSEAL%2Fblob%2Fmaster%2Fnative%2Fsrc%2Fseal%2Futil%2Fsmallntt.cpp%23L229&data=02%7C01%7Cwei.dai%40microsoft.com%7Cd264ba6e4f69461a34c508d72c518b29%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637026601046507494&sdata=v0cO1S09rWBAT3Uftq%2F9I%2BXbcAr7IyE0KJK3P0ZhKeI%3D&reserved=0> Should it be [0, 4p) ? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FSEAL%2Fissues%2F56%3Femail_source%3Dnotifications%26email_token%3DABK7SAO7TGZEYJXLC7KY75TQG52INA5CNFSM4IR6YSX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIDXSKA&data=02%7C01%7Cwei.dai%40microsoft.com%7Cd264ba6e4f69461a34c508d72c518b29%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637026601046517487&sdata=Scl9phdX6n3WCTgFxj82cNDqknRxF5%2BsqhoyLk0uXd8%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABK7SAPIGXZYIWRFASA6YXDQG52INANCNFSM4IR6YSXQ&data=02%7C01%7Cwei.dai%40microsoft.com%7Cd264ba6e4f69461a34c508d72c518b29%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637026601046517487&sdata=5fHOX9VcMDh3Ut8yu%2BCR2N5NiuSfqYwBbhJlBhZi8TY%3D&reserved=0>.