Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does CUDA 12.4.0 still need _NODISCARD_FRIEND? #4104

Closed
StephanTLavavej opened this issue Oct 19, 2023 · 0 comments · Fixed by #4782
Closed

Does CUDA 12.4.0 still need _NODISCARD_FRIEND? #4104

StephanTLavavej opened this issue Oct 19, 2023 · 0 comments · Fixed by #4782
Labels
enhancement Something can be improved fixed Something works now, yay!

Comments

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Oct 19, 2023

From this timeline, I suspect, but haven't confirmed, that we no longer need this workaround. If someone has time to check, that would be great. (I don't think our minimal CUDA test coverage is detailed enough to have confidence that simply removing the workaround and looking for test failures would be sufficient validation.)

@StephanTLavavej StephanTLavavej added help wanted Extra attention is needed question Further information is requested labels Oct 19, 2023
@StephanTLavavej StephanTLavavej changed the title Does CUDA 11.6.0 still need _NODISCARD_FRIEND? Does CUDA 12.4.0 still need _NODISCARD_FRIEND? May 28, 2024
@StephanTLavavej StephanTLavavej added enhancement Something can be improved fixed Something works now, yay! and removed help wanted Extra attention is needed question Further information is requested labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved fixed Something works now, yay!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant