Toolset update: VS 2022 17.10 Preview 2, WinSDK 22621, CUDA 12.4.0 #4475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Changelog
⚙️ Details
WinSDK
WinSDK 22621 is now used by the MSVC-internal build (this was MSVC-PR-407828 which flowed into
prod/fe
via MSVC-PR-528863 on 2024-02-15).In
CMakeLists.txt
, this definesNTDDI_VERSION=NTDDI_WIN10_NI
to make the latest machinery available, although we don't need any of it yet. #2714 was when we last increased this to the maximum supported value (gettingFILE_DISPOSITION_INFO_EX
along the way). Note: Just because the latest machinery is declared, doesn't mean that we'll start requiring the latest OS - we always have runtime OS checks when attempting to actually use new machinery.CUDA
CUDA 12.4.0 is the first version that allows VS 2022 17.10 (
_MSC_VER
1940
), allowing us to remove--allow-unsupported-compiler
(recently added by #4392). The last time we increased our requirement was #2791 when CUDA 11.6.0 began supporting VS 2022.Note that our escape hatch
_ALLOW_COMPILER_AND_STL_VERSION_MISMATCH
remains available if a user can't upgrade their CUDA at the same time as their VS for some reason.AV exclusions
I'm dropping the AV exclusions in
provision-image.ps1
. Nobody has hissed at us yet, but I saw MSVC-PR-533609 making similar changes in MSVC-internal scripts, so I think we should do this now (even though our VMs are, of course, completely untrusted, unprivileged, and ephemeral).Compiler bug workaround removals
nullptr
inconstexpr
", fixed 2023-10-30.NON-GitHub change required to define
NTDDI_VERSION
toNTDDI_WIN10_NI
insrc/vctools/crt/crt-common.settings.targets
.