Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2022 17.10 Preview 1 #4392

Merged
merged 40 commits into from
Feb 16, 2024

Conversation

StephanTLavavej
Copy link
Member

Overview

  • Code cleanups:
    • Removed compiler bug workarounds.
  • Infrastructure improvements:
    • Updated dependencies.
      • Updated build compiler to VS 2022 17.10 Preview 1 (now required).
      • Updated CMake to 3.28 (now required).
      • Updated Python to 3.12.2.

Commits

StephanTLavavej and others added 30 commits February 13, 2024 12:45
VSO-1956799 "C1XX constexpr ICE when invoking a base PMD on a reference_wrapper<Derived>"
On 2018-04-20, amyw-msft noted: "We actually fixed this in RS1"
We aren't testing Clang with header units and modules yet, but we require Clang 17, and this aligns with how we changed `<source_location>` in GH 4259.
…ry_modules.

This activates `#include`-then-`import` coverage.
Not all - only the `using` scenario was fixed. We were wrong about the other scenario.
std::atomic_wait() and std::atomic_wait_explicit() are top-level (namespace-scope) functions, so C++20 Down With Typename doesn't apply to them, regardless of the `const`. MSVC, Clang, and EDG all agree.
@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Feb 15, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner February 15, 2024 02:38
@StephanTLavavej
Copy link
Member Author

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

stl/inc/format Show resolved Hide resolved
@CaseyCarter CaseyCarter removed their assignment Feb 16, 2024
@StephanTLavavej StephanTLavavej merged commit 64e410c into microsoft:main Feb 16, 2024
37 checks passed
@StephanTLavavej StephanTLavavej deleted the vs17.10p1 branch February 16, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants