-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolset update: VS 2022 17.10 Preview 1 #4392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSO-1956799 "C1XX constexpr ICE when invoking a base PMD on a reference_wrapper<Derived>"
To be more searchable.
On 2018-04-20, amyw-msft noted: "We actually fixed this in RS1"
We aren't testing Clang with header units and modules yet, but we require Clang 17, and this aligns with how we changed `<source_location>` in GH 4259.
…ry_modules. This activates `#include`-then-`import` coverage.
Not all - only the `using` scenario was fixed. We were wrong about the other scenario.
std::atomic_wait() and std::atomic_wait_explicit() are top-level (namespace-scope) functions, so C++20 Down With Typename doesn't apply to them, regardless of the `const`. MSVC, Clang, and EDG all agree.
…O-1956627. VSO-1956627 "EDG emits bogus error 'expression must have a constant value' when using a named nullptr_t parameter" I'm changing all operators for consistency, even when they aren't constexpr.
…SVC doesn't. LLVM-49072 was fixed. Reported LLVM-81774 and VSO-1956558 (EDG).
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Commits
constexpr
ICE when invoking a base PMD on areference_wrapper<Derived>
".if constexpr
llvm/llvm-project#44743 (resolved as duplicate) => LLVM-35450 Spurious -Wunused-lambda-capture in presence of "if constexpr" llvm/llvm-project#34798google/sanitizers#295
test_header_units_and_modules.hpp
.<source_location>
in Toolset update: VS 2022 17.9 Preview 2, Clang 17 #4259.P0009R18_mdspan_mdspan
.P2374R4_views_cartesian_product_recommended_practices
._MSVC_INTERNAL_TESTING
workaround inP1208R6_source_location
._MSVC_INTERNAL_TESTING
workarounds inP2465R3_standard_library_modules
.#include
-then-import
coverage.using
scenario was fixed. We were wrong about the other scenario.std::atomic_wait()
andstd::atomic_wait_explicit()
are top-level (namespace-scope) functions, so C++20 Down With Typename doesn't apply to them, regardless of theconst
. MSVC, Clang, and EDG all agree.nullptr_t
parameter".constexpr
.constexpr type_info
ICE) which just shipped.basic_format_arg
: Clang and EDG still need it, MSVC doesn't.--allow-unsupported-compiler
toGH_000639_nvcc_include_all
.backslashreplace
to avoid UNRESOLVED tests #4366.min/max_element
using SSE4.1 for floats #3928.