-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Closed
Labels
fixedSomething works now, yay!Something works now, yay!good first issueGood for newcomersGood for newcomersinfrastructureRelated to repository automationRelated to repository automation
Description
When VS 2019 16.6 Preview 1 is available, the shipping toolset will support #6 constexpr is_sorted(). At that time, this will become a "good first issue".
- We'll need to build the tools with
/std:c++latest. This is accomplished by telling CMake to use C++20 instead of C++17:
Line 7 in a46d897
| set(CMAKE_CXX_STANDARD 17) |
- Then we can remove this comment ("TRANSITION" means "TODO" for us), and change each
asserttostatic_assert:
STL/tools/validate/validate.cpp
Lines 174 to 177 in a46d897
| // TRANSITION, P0202R3, use constexpr is_sorted() | |
| assert(is_sorted(skipped_directories.begin(), skipped_directories.end())); | |
| assert(is_sorted(skipped_extensions.begin(), skipped_extensions.end())); | |
| assert(is_sorted(tabby_filenames.begin(), tabby_filenames.end())); |
(Related to #224.)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
fixedSomething works now, yay!Something works now, yay!good first issueGood for newcomersGood for newcomersinfrastructureRelated to repository automationRelated to repository automation