Code cleanup: Brace for impact #1020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Jul 8, 2020
Contributor
|
|
mnatsuhara
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're increasingly using braces to construct temporary objects in product code. This makes expressions more readable because braces don't look like function calls.
This PR changes all occurrences of
meow<>()tomeow<>{}(missed by previous rounds of search-and-replace due to the "diamond"). These are the transparent operator function objects (primarilyequal_toandless, also a fewplus,minus, andmultipliesin<numeric>).Then, this changes
meow<>{}tomeow{}in C++17-and-later code, where Class Template Argument Deduction is available. (We were already usingmeow{}in a few places, so this is increasing consistency. Of course, this creates a difference between C++14 and C++17 styles, but I think it's reasonable to take advantage of CTAD when possible.)