Skip to content

Conversation

@CaseyCarter
Copy link
Contributor

Partially addresses #39.

@CaseyCarter CaseyCarter added cxx20 C++20 feature ranges C++20/23 ranges labels Jul 10, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner July 10, 2020 04:46
@CaseyCarter CaseyCarter mentioned this pull request Jul 10, 2020
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits

Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions. And a tacocat, which is its own reverse. 🌮 🐱

Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I have two questions 😺

@mnatsuhara mnatsuhara self-assigned this Jul 15, 2020
@StephanTLavavej StephanTLavavej self-assigned this Jul 17, 2020
@StephanTLavavej StephanTLavavej merged commit 4f949af into microsoft:master Jul 20, 2020
@StephanTLavavej
Copy link
Member

😺 ! @ahanamuk dna @CaseyCarter sknahT

@CaseyCarter CaseyCarter deleted the reverse branch July 21, 2020 00:22
CaseyCarter added a commit to CaseyCarter/STL that referenced this pull request Jul 28, 2020
Co-authored-by: Ahana Mukhopadhyay <t-ahmukh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cxx20 C++20 feature ranges C++20/23 ranges

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants