-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Implement ranges::unique family #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
|
For whatever reasons @github does not update the branch. Seems it has trouble |
|
GitHub apparently had some downtime earlier, but I see a code format validation failure because my requested comment edit made the line exceed 120 characters 😹 I think if you fix that, it should pass? |
|
I already fixed that and pushed it to github so I do not really know what to do that it picks up the new commit |
I recommend embracing that fact that each of the generator templates is going to generate cases that are handled by each of the three backends in the algorithm. Analyze |
Co-authored-by: Casey Carter <cartec69@gmail.com>
CaseyCarter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after addressing Stephan's comments.
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
|
hiss at clang I guess we should limit some of the instantiations here |
|
So
|
|
As far as I can tell the new unwrapping for continuous ranges leads to the ICE. If i go back to b4fb1f9 and add that lines and the changes to |
|
ssiH at |
Yes; I applied the |
StephanTLavavej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo two trivial nitpicks.
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
|
Thanks for your, err, one-of-a-kind contribution. |
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net> Co-authored-by: Casey Carter <Casey@Carter.net>
This implements
ranges::uniqueandranges::unique_copy.@CaseyCarter: Any good idea on how to test which implementation is actually used? I thought about counting inside the projection if the projected object lies within
inputoroutputor somewhere else. But that does not fully work because some of the combinations of the store path trigger the higher ones.