Implement Ranges Set Operations #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `mergeable` concept * algorithms: `ranges::includes`, `ranges::set_union`, `ranges::set_intersection`, `ranges::set_difference`, and `ranges::set_symmetric_difference`.
Closed
miscco
reviewed
Jul 14, 2020
miscco
reviewed
Jul 14, 2020
miscco
reviewed
Jul 14, 2020
| _Get_unwrapped(_STD move(_Last1)), _Get_unwrapped(_STD move(_First2)), | ||
| _Get_unwrapped(_STD move(_Last2)), _Get_unwrapped_unverified(_STD move(_Result)), _Pass_fn(_Pred), | ||
| _Pass_fn(_Proj1), _Pass_fn(_Proj2)); | ||
| _Seek_wrapped(_First1, _STD move(_UResult.in1)); |
Contributor
There was a problem hiding this comment.
I am wondering whether this one would be helpful (If yes than it is future work. No change requested):
template<class _It1, class _It2, class _Out, class _UIt1, class _UIt2, class _UOut>
in_in_out_result<_It1, _It2, _Out> _Seek_wrapped(_It1& _In1, _It2& _In2, _UOut& _Out, in_in_out_result<_UIt1, _UIt2, _UOut>&& _UResult);Same for in_out_result and in_in_result which occur often enough that it makes sense
Contributor
Author
There was a problem hiding this comment.
Probably so. I think we should add a work item to scan through the unwrapping and rewrapping to find opportunities for simplification after/in conjunction with the pass to unwrap result iterators with _Get_unwrapped_n.
StephanTLavavej
requested changes
Jul 15, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good, very small suggestions.
StephanTLavavej
approved these changes
Jul 15, 2020
mnatsuhara
approved these changes
Jul 27, 2020
Contributor
Author
|
I'm having trouble coming up with a witty comment here... perhaps a limerick? What rhymes with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mergeableconceptalgorithms:
ranges::includes,ranges::set_union,ranges::set_intersection,ranges::set_difference, andranges::set_symmetric_difference.Partially addresses #39.