Implement ranges::move_backward #1053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
StephanTLavavej
requested changes
Jul 17, 2020
miscco
reviewed
Jul 18, 2020
CaseyCarter
commented
Jul 19, 2020
StephanTLavavej
requested changes
Jul 21, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good, requesting changes only for the namespace-scope static.
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
StephanTLavavej
approved these changes
Jul 22, 2020
mnatsuhara
approved these changes
Jul 27, 2020
Co-authored-by: mnatsuhara <46756417+mnatsuhara@users.noreply.github.com>
Contributor
Author
|
I appreciate this contribution, but I can't help but feel that we're moving backward when we should be moving forward. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.