Skip to content

Conversation

@miscco
Copy link
Contributor

@miscco miscco commented Jul 18, 2020

This implements the range::shuffle algorithm.

For whatever reason it mt19937 has -at least locally- problems fulfilling the uniform_random_bit_generator<remove_reference<_Urng>> requirement, which is peculiar as it does in the ranges::sample test.

@miscco miscco requested a review from a team as a code owner July 18, 2020 20:20
Copy link
Contributor

@statementreply statementreply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments also apply to ranges::sample. (Apparently the test for ranges::sample didn’t catch this)

Co-authored-by: statementreply <statementreply@gmail.com>
@miscco
Copy link
Contributor Author

miscco commented Jul 19, 2020

Derp, thanks a lot

@miscco miscco changed the title Implement range::shuffle Implement ranges::shuffle Jul 19, 2020
@miscco
Copy link
Contributor Author

miscco commented Jul 19, 2020

Merged with #1052

@miscco miscco closed this Jul 19, 2020
@miscco miscco deleted the ranges_shuffle branch September 4, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants