Latch, Semaphore, Barrier (part of #52, P1135R6) #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
so let's keep debug
# Conflicts: # stl/CMakeLists.txt # stl/inc/atomic # stl/inc/yvals_core.h # tests/libcxx/expected_results.txt # tests/libcxx/skipped_tests.txt # tests/std/test.lst
# Conflicts: # tests/std/test.lst
# Conflicts: # stl/inc/atomic # stl/src/parallel_algorithms.cpp
…should be directly visible in the places doing them where possible even at the cost of some verbosity. Move parallel algorithms support to the DLL since it wants to use the wait functions infrastructure. Change the 'vulcan nerve pinch' __std_atomic_set_api_level to not use VersionHelpers which is not always avaialble for some restricted environments. Fix a missed _2 rename.
Add the LIBRARY LIBRARYNAME bits that the other satellite DLLs use Add parallel_algorithms.cpp and atomic_wait.cpp to static libs
BillyONeal
reviewed
Aug 25, 2020
BillyONeal
reviewed
Aug 25, 2020
BillyONeal
reviewed
Aug 25, 2020
BillyONeal
reviewed
Aug 25, 2020
BillyONeal
reviewed
Aug 25, 2020
BillyONeal
reviewed
Aug 25, 2020
BillyONeal
reviewed
Aug 25, 2020
BillyONeal
suggested changes
Aug 25, 2020
Member
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
remove superfluous default order, remove relaxed for try_acquire
BillyONeal
approved these changes
Aug 25, 2020
StephanTLavavej
requested changes
Aug 25, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Thanks! I found a few nitpicks, and one stealth build break, but otherwise this looks good to me.
STL review Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
StephanTLavavej
approved these changes
Aug 29, 2020
Contributor
|
Thanks for your contribution of the entire C++20 synchronization library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #52