Skip to content

Fix thinko in ranges::iter_swap #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CaseyCarter merged 2 commits into from
Jul 30, 2020
Merged

Fix thinko in ranges::iter_swap #1072

CaseyCarter merged 2 commits into from
Jul 30, 2020

Conversation

@CaseyCarter
Copy link
Contributor

@CaseyCarter CaseyCarter commented Jul 21, 2020 •
edited
Loading

...by transposing arguments to _Iter_exchange_move.

Fixes #1067

Blocking #1062.

@CaseyCarter
Fix thinko in ranges::iter_swap
7cce0a0 
...by transposing arguments to `_Iter_exchange_move`.

Fixes microsoft#1067
@CaseyCarter CaseyCarter added the bug Something isn't working label Jul 21, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner July 21, 2020 17:45
@miscco
Copy link
Contributor

miscco commented Jul 21, 2020

Did you really swap the arguments

@CaseyCarter CaseyCarter mentioned this pull request Jul 21, 2020
Merged
StephanTLavavej
StephanTLavavej requested changes Jul 22, 2020
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I can’t unsee pre-existing lines! 😹

@StephanTLavavej StephanTLavavej added the ranges C++20/23 ranges label Jul 22, 2020
@CaseyCarter CaseyCarter self-assigned this Jul 29, 2020
@CaseyCarter CaseyCarter merged commit 30777d5 into microsoft:master Jul 30, 2020
@CaseyCarter CaseyCarter deleted the iter_swap_fix branch July 30, 2020 03:57
@CaseyCarter
Copy link
Contributor Author

CaseyCarter commented Jul 30, 2020

Thanks for writing buggy code to guarantee yourself job safety err, fixing this tragic bug.

@CaseyCarter CaseyCarter removed their assignment Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+1 more reviewer

@cbezault cbezault cbezault approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<xutility>: ranges::iter_swap is broken

4 participants

@CaseyCarter @miscco @cbezault @StephanTLavavej