Implement ranges::rotate and ranges::rotate_copy #1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
CaseyCarter
suggested changes
Jul 23, 2020
Contributor
Author
|
Urgh, from all the algorithms where I would not want to reduce an ICE out from rotate is high in the list |
Contributor
I've got this fixed, just typing up a commit message. |
* Unqualify calls to `_Reverse_common`, which cannot be confused with a `_Meow_unchecked` function in `_STD`. * In `_Rotate_unchecked`: * Name the iterator value that's equal to the sentinel `_Final` instead of `_End` which has become conventional. * Avoid making an extra traversal ahead-of-time to find the final iterator of non-bidi ranges. * When we do need to find the final iterator value, start any traversal at `_Mid` instead of `_First`. * Let's not overload "sentinel" - which has enough meanings in Ranges - for `_Reverse_until_sentinel_unchecked`. * Don't test `constexpr rotate` at all with MSVC: it's extremely sensitive to VSO-938163. * Remove unnecessary bug workarounds from the `rotate_copy` test.
Contributor
Correction: I had this fixed, and somehow managed to break it again while typing a commit message. |
CaseyCarter
approved these changes
Jul 28, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
StephanTLavavej
changed the title
Contributor
|
"That's obviously a rotate." -- Sean Parent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been rotating to implement these algorithms but ended up with an ICE in my hand.