Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_Uglify the current member of move_iterator #1080

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Jul 23, 2020

Looking at counted_iterator I found that move_iterator has a non-ugly member current. The same for reverse_iterator

As this is a purely private member it is not user accessible and should be _Ugly

@miscco miscco requested a review from a team as a code owner July 23, 2020 06:53
stl/inc/xutility Outdated Show resolved Hide resolved
stl/inc/xutility Outdated Show resolved Hide resolved
stl/inc/xutility Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Jul 23, 2020
@StephanTLavavej StephanTLavavej changed the title _Uglify the current member of reverse/move iterator _Uglify the current member of move_iterator Jul 23, 2020
@StephanTLavavej
Copy link
Member

For final review, we should think about the bincompat consequences. (I think they're acceptable, as mentioned above.)

@CaseyCarter
Copy link
Member

For final review, we should think about the bincompat consequences. (I think they're acceptable, as mentioned above.)

I don't recall CLR metadata knowing about access control at all, or caring about the names of members: it's primarily concerned with the sizes of non-static data members and their offsets within the complete object's layout. (We even had success with the <atomic> changes moving the first data member into a base class.) Altogether, I'm not concerned about bincompat here since we still have an object of type iterator_type in the same location.

@CaseyCarter CaseyCarter self-assigned this Jul 27, 2020
@CaseyCarter CaseyCarter merged commit f49ffaf into microsoft:master Jul 27, 2020
@CaseyCarter
Copy link
Member

Thank you for making our code, and our lives, a little _Uglier.

@CaseyCarter CaseyCarter removed their assignment Jul 27, 2020
@miscco miscco deleted the fix_move_iterator branch July 27, 2020 18:47
CaseyCarter pushed a commit to CaseyCarter/STL that referenced this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants