Skip to content

Implement ranges::reverse_copy #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 6 commits into from
Aug 5, 2020
Merged

Implement ranges::reverse_copy #1095

StephanTLavavej merged 6 commits into from
Aug 5, 2020
+269 −2

Conversation

@CaseyCarter
Copy link
Contributor

@CaseyCarter CaseyCarter commented Jul 27, 2020

No description provided.

@CaseyCarter CaseyCarter added cxx20 C++20 feature ranges C++20/23 ranges labels Jul 27, 2020
@CaseyCarter CaseyCarter requested a review from a team as a code owner July 27, 2020 20:18
@CaseyCarter CaseyCarter mentioned this pull request Jul 27, 2020
Closed
miscco
miscco reviewed Jul 27, 2020
View reviewed changes
StephanTLavavej
StephanTLavavej approved these changes Jul 29, 2020
View reviewed changes
@mnatsuhara mnatsuhara self-assigned this Jul 29, 2020
@StephanTLavavej
Merge branch 'master' into reverse_copy
1a195b8
@StephanTLavavej
Sort tests/std/test.lst.
ca7b87e 
"alg_" sorts before "algo", according to ASCII and VSCode.
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jul 30, 2020

I've pushed a merge to resolve a "take both changes" conflict in tests/std/test.lst. I pushed a separate commit to fix a sorting issue I had noticed recently (this makes it easier to diff test.lst against dir /s /b /ad).

mnatsuhara
mnatsuhara approved these changes Aug 4, 2020
View reviewed changes
@CaseyCarter CaseyCarter requested a review from mnatsuhara August 5, 2020 02:20
@CaseyCarter CaseyCarter removed their assignment Aug 5, 2020
@StephanTLavavej StephanTLavavej self-assigned this Aug 5, 2020
@StephanTLavavej StephanTLavavej merged commit 622b62a into microsoft:master Aug 5, 2020
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Aug 5, 2020

Thanks for implementing this algorithm and accelerating it with @pawREP's #804!

@CaseyCarter CaseyCarter deleted the reverse_copy branch August 5, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@miscco miscco miscco left review comments

@mnatsuhara mnatsuhara mnatsuhara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

cxx20 C++20 feature ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CaseyCarter @StephanTLavavej @miscco @mnatsuhara