Skip to content

Remove timing assumption that causes test to fail spuriously #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StephanTLavavej merged 2 commits into from
Aug 3, 2020
Merged

Remove timing assumption that causes test to fail spuriously #1129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
159472b
remove timing assumption
AlexGuteniev Aug 2, 2020
7e2e57b
Update tests/std/include/test_atomic_wait.hpp
AlexGuteniev Aug 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/std/include/test_atomic_wait.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,11 @@ void test_atomic_wait_func(const UnderlyingType old_value, const UnderlyingType
add_seq('4');
a.store(new_value);
a.notify_one();
#ifdef CAN_FAIL_ON_TIMING_ASSUMPTION
// timing assumption that the main thread evaluates the `wait(old_value)` before this timeout expires
std::this_thread::sleep_for(waiting_duration);
add_seq('6');
#endif // CAN_FAIL_ON_TIMING_ASSUMPTION
});

a.wait(old_value);
Expand All @@ -52,7 +54,12 @@ void test_atomic_wait_func(const UnderlyingType old_value, const UnderlyingType
thd.join();

add_seq('\0');

#ifdef CAN_FAIL_ON_TIMING_ASSUMPTION
assert(strcmp(seq, "123456") == 0);
#else
assert(strcmp(seq, "12345") == 0);
#endif
}

template <class UnderlyingType>
Expand Down