Skip to content

Conversation

@AlexGuteniev
Copy link
Contributor

Another piece of #52

@StephanTLavavej StephanTLavavej changed the title wait/notify atomic<shared_ptr<T> (#52, P1644R0) wait/notify atomic<shared_ptr<T>> (#52, P1644R0) Aug 3, 2020
@StephanTLavavej StephanTLavavej added the cxx20 C++20 feature label Aug 3, 2020
@BillyONeal
Copy link
Member

This strategy looks good to me 👍

@AlexGuteniev AlexGuteniev marked this pull request as ready for review August 4, 2020 18:06
@AlexGuteniev AlexGuteniev requested a review from a team as a code owner August 4, 2020 18:06
@AlexGuteniev
Copy link
Contributor Author

I think this is ready for review

Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM modulo Stephan's nitpicks. Thanks!

AlexGuteniev and others added 3 commits August 5, 2020 19:08
Co-authored-by: Adam Bucior <35536269+AdamBucior@users.noreply.github.com>
@StephanTLavavej StephanTLavavej merged commit bdf7710 into microsoft:master Aug 9, 2020
@StephanTLavavej
Copy link
Member

Thanks for implementing this feature! I can't wait to notify our users that another part of the C++20 Synchronization Library will be available! 😸

@AlexGuteniev AlexGuteniev deleted the atomic_shared_ptr_wait branch August 10, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cxx20 C++20 feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants