Implement ranges::uninitialized_move #1137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<algorithm>` * Promote `_Convertible_from` and `in_out_result` to `<xutility>` for use by `ranges::_Uninitialized_move_unchecked`. `<xmemory>` * Teach `_Destroy_in_place` to destroy arrays. * Teach `_Destroy_range` to accept different sentinel types. * Implement exposition-only concepts `_No_throw_input_iterator`, `_No_throw_sentinel_for`, and `_No_throw_forward_iterator` (with test coverage in `tests/std/tests/P0896R4_ranges_algorithm_machinery`). * Implement `ranges::_Uninitialized_move_unchecked` to support Range algorithms which allocate. `<memory>` * Implement exposition-only concepts `_No_throw_input_range` and `_No_throw_forward_range` (with test coverage in `tests/std/tests/P0896R4_ranges_algorithm_machinery`). * Implement `ranges::uninitialized_move` in terms of `ranges::_Uninitialized_move_unchecked` (with test `tests/std/tests/P0896R4_ranges_alg_uninitialized_move`). `tests/std/include/range_algorithm_support.hpp` * `test::iterator`'s `iter_move` should yield an xvalue instead of a prvalue to eliminate the redundant extra move in `*x = iter_move(y)`.
Closed
StephanTLavavej
requested changes
Aug 4, 2020
miscco
reviewed
Aug 4, 2020
Contributor
Author
|
There were substantial changes here after review, so I'm moving this back to Initial Review. |
CaseyCarter
commented
Aug 5, 2020
CaseyCarter
commented
Aug 5, 2020
CaseyCarter
changed the title
ranges::uninitialized_move
StephanTLavavej
approved these changes
Aug 5, 2020
Member
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
I see no remaining issues except for a spelling nitpick.
…cular almost-word
StephanTLavavej
approved these changes
Aug 6, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
miscco
reviewed
Aug 10, 2020
mnatsuhara
approved these changes
Aug 11, 2020
StephanTLavavej
approved these changes
Aug 11, 2020
Member
|
Thanks! I don't have a funny joke here - this is simply raw space where a funny joke can be move-constructed later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<algorithm>_Convertible_fromandin_out_resultto<xmemory>for use by the specialized memory algorithms in<memory>, (notably includingranges::uninitialized_move).<xmemory>_Destroy_in_placeto destroy arrays._Destroy_rangeto accept different sentinel types.<memory>_No_throw_input_iterator,_No_throw_sentinel_for,_No_throw_forward_iterator,_No_throw_input_range, and_No_throw_forward_range(with test coverage intests/std/tests/P0896R4_ranges_algorithm_machinery).ranges::uninitialized_move(with testtests/std/tests/P0896R4_ranges_alg_uninitialized_move).tests/std/include/range_algorithm_support.hpptest::iterator'siter_moveshould yield an xvalue instead of a prvalue to eliminate the redundant extra move in*x = iter_move(y).