-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Disable a libcxx test due to the impact of P0960R3 #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Casey Carter <cartec69@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
StephanTLavavej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, checks finally passed!
|
MSVC-PR-265344 has passed tests; when @JonCavesMSFT merges that, I'll merge this. |
|
Thanks for keeping our test suite working with MSVC! (I don't believe this change needs to be listed in our ChangeLog; shout if you disagree. I did add #1152 to track changing the SKIPPED to a FAIL when the corresponding compiler becomes the STL toolset.) |
The adoption of P0960R3 (Allow initializing aggregates from a parenthesized list of values) has caused code like the following to change behavior:
This code used to be accepted but because P0960R3 changes the value of
std::is_constructible_v<S, int>fromfalsetotruethe compiler ends up choosing a different tuple constructor and, eventually, emits an error message:It was suggested, by Casey Carter, that I disable this test until std::tuple can be updated to handle the new C++20 rules.