Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build warning "restarting link with /LTCG". #1140

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Fix build warning "restarting link with /LTCG". #1140

merged 1 commit into from
Aug 5, 2020

Conversation

StephanTLavavej
Copy link
Member

Fixes #1139. Followup to #593.

This links the atomic_wait satellite with /LTCG;/opt:ref,icf (release) or /opt:ref,noicf (debug):

STL/stl/CMakeLists.txt

Lines 509 to 510 in b74b618

add_stl_dlls("" "" "${VCLIBS_RELEASE_OPTIONS}" "/GL" "/LTCG;/opt:ref,icf")
add_stl_dlls("d" "_DEBUG" "${VCLIBS_DEBUG_OPTIONS}" "" "/opt:ref,noicf")

@StephanTLavavej StephanTLavavej added the build Related to the build system label Aug 3, 2020
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner August 3, 2020 23:00
@BillyONeal
Copy link
Member

I am sad that /WX allowed this. I saw it during testing but had not touched our build in long enough I thought it must have been normal.

@StephanTLavavej StephanTLavavej self-assigned this Aug 5, 2020
@StephanTLavavej StephanTLavavej merged commit 06c2c54 into microsoft:master Aug 5, 2020
@StephanTLavavej StephanTLavavej deleted the ltcg_warning branch August 5, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
build Related to the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build warning "restarting link with /LTCG" emitted for atomic_wait.cpp.obj
3 participants
@StephanTLavavej @BillyONeal @CaseyCarter