Cache hardware thread count for <execution> #1143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves microsoft#1134 (conservatively) revert to what there were before atomic wait
CaseyCarter
suggested changes
Aug 4, 2020
Co-authored-by: Casey Carter <cartec69@gmail.com>
Member
|
It looks like we can remove |
BillyONeal
reviewed
Aug 4, 2020
BillyONeal
approved these changes
Aug 4, 2020
Member
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
LGTM with minor nitpicks about including more headers than we need and about lots of conversions
Co-authored-by: Billy O'Neal <bion@microsoft.com>
…lexGuteniev/STL into cache_execution_hw_concurrency
BillyONeal
approved these changes
Aug 5, 2020
CaseyCarter
approved these changes
Aug 5, 2020
BillyONeal
changed the title
StephanTLavavej
approved these changes
Aug 6, 2020
Member
|
Thanks for restoring this performance optimization! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1134 (conservatively)
revert to what there were before atomic wait