Test _Countl_zero_bsr with a dedicated test #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
reviewed
Aug 10, 2020
barcharcraz
approved these changes
Aug 11, 2020
Contributor
barcharcraz
left a comment
barcharcraz
left a comment
There was a problem hiding this comment.
Looks great to me, after billy's comment is resolved
StephanTLavavej
requested changes
Aug 15, 2020
STL suggestions Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
CaseyCarter
reviewed
Aug 15, 2020
Contributor
CaseyCarter
left a comment
CaseyCarter
left a comment
There was a problem hiding this comment.
Fixed the merge conflict and a typo I noticed.
StephanTLavavej
approved these changes
Aug 16, 2020
Member
|
Thanks for improving this test coverage! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1120
I thought about it a bit and think that a direct test is enough.